Thank you for providing the DotNetZip library. It's been wonderful so far.
\r\nI'm having some trouble with replacing the SFX stub though. I'd like to provide the same "use" as the current SFX, just with a couple more options in the UI (I do some preprocessing on the files before they are extracted).
\r\nI read the thread at: http://dotnetzip.codeplex.com/Thread/View.aspx?ThreadId=70602
\r\nSpecifically the post from Oct 15 2009 at 12:32 AM
\r\n
I implemented your logic, and can create the exe fine:
string outputFile = "sfx.exe";
string sfxStub = "Stub.exe";
byte[] buffer = new byte[4000];
using (System.IO.FileStream output = new FileStream(outputFile, FileMode.Create))
using (ZipFile zip = new ZipFile())
using (System.IO.FileStream input = new FileStream(sfxStub, FileMode.Open))
{
zip.AddFile("test.txt");
int n = 1;
while ((n = input.Read(buffer, 0, buffer.Length)) > 0)
{
output.Write(buffer, 0, n);
}
zip.Save(output);
}
\r\n
But when I attempt to read it back in, inside the stub, I get a System.IO.FileNotFound exception on the using line:
\r\n Assembly assembly = Assembly.GetExecutingAssembly();
using (Ionic.Zip.ZipFile file = ZipFile.Read(assembly.Location))
\r\n
The other thing I realized, if I use this method, dependencies won't be included in the EXE will it? Should I run ILMerge after builds to merge the required assemblies into the stub exe, so that it's self contained?
\r\nThanks for any help.
", "PostedDate": "2010-04-29T07:49:39.377-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "437281", "ThreadId": "211020", "Html": "I don't know what I wrote in October, but just for clarity, I think you might want to structure your creation logic like this:
\r\npublic void CreateSfx()\r\n{\r\n string outputFile = "sfx.exe";\r\n string sfxStub = "Stub.exe";\r\n\r\n byte[] buffer = new byte[4000];\r\n\r\n using (System.IO.FileStream output = new FileStream(outputFile, FileMode.Create))\r\n {\r\n using (System.IO.FileStream input = new FileStream(sfxStub, FileMode.Open))\r\n {\r\n int n = 1;\r\n while ((n = input.Read(buffer, 0, buffer.Length)) > 0)\r\n {\r\n output.Write(buffer, 0, n);\r\n }\r\n\r\n } \r\n using (ZipFile zip = new ZipFile())\r\n {\r\n zip.AddFile("test.txt");\r\n zip.Save(output);\r\n }\r\n }\r\n}\r\n
To me that is much more readable - it clearly shows writing the stub into the output stream, then saving the zip file into the same stream.
\r\nNow, as for why you are getting a FileNotFoundException, you didn't provide the complete exception so I can't know what file it is. I suggest that you examine the assembly.Location and see if it makes sense to you. It should be the path to a regular filesystem file, specifically the SFX exe that you created.
\r\nRegarding dependencies, yes, the SFX that you create this way will depend on the Ionic.Zip.dll . If you want a single-exe deployment, then normally you would need to use ILMERGE. But I think that ILMerge cannot preserve the signature of a strongly-named assembly when merging them, unless you have the key that was used for signing. Ionic.Zip.dll is strongly-named, and you don't have the key, therefore I don't think you can use ILMerge to embed Ionic.Zip.dll into your assembly. The workaround is to embed the Ionic.Zip.dll into the EXE as a resource.
", "PostedDate": "2010-04-29T12:13:39.16-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "437288", "ThreadId": "211020", "Html": "\r\n
Thanks for the quick reply. I meant to paste the entire exception, but somehow didn't. In collecting it just now though, I realized what the problem is. I was carelessly missing the Ionic.Zip assembly, so the FileIOException was it couldn't be found. Moving to a directory with the assemblies, it all works as expected.
\r\n\r\n
Now I'm on to read about embedding as a resource. Thanks for pointing me to that.
\r\n", "PostedDate": "2010-04-29T12:35:06.303-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "437305", "ThreadId": "211020", "Html": "
Thanks for the help thus far. I seem to have it working, but with a small hack.
\r\nI have embedded Ionic.Zip.dll as a resource, and set the build action to "Embedded Resource".
\r\nIn ResolveEventArgs.Name, it is passing "Ionic.Zip, Version=1.9.1.5, Culture=neutral, PublicKeyToken=edbe51ad942a3f5c".
\r\nIf I call Assembly.GetExecutingAssembly().GetManifestResourceNames(), I see MyStub.Resources.Ionic.Zip.dll
\r\nI'm sure it's something simple like I embedded the resource wrong, but is there a way to translate the names? If I replace the call
\r\n\r\n
Stream s = a1.GetManifestResourceStream(args.Name);
\r\nwith
\r\nStream s = a1.GetManifestResourceStream("MyStub.Resources.Ionic.Zip.dll");
\r\n\r\n
everything works great. Sorry for the somewhat offtopic question.
\r\n", "PostedDate": "2010-04-29T13:24:33.233-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "437347", "ThreadId": "211020", "Html": "
Yep - your logic that receives the assembly name ("Ionic.Zip, Version=1.9....etc") needs to return an assembly.
Sounds like you already know how to do that. If the name begins with Ionic.Zip, then you know it wants the resource stream with the name MyStub.Resources.Ionic.Zip.dll.
Maybe you are concerned about the name mismatch. But the names of embedded streams are part of a different naming scope than the assemblies. So, the fact that the resource stream is not named "Ionic.Zip.dll" is not a concern, as long as you know how to map between names of resource streams and names of assemblies that you need to resolve.
\r\n\r\n
\r\n
", "PostedDate": "2010-04-29T16:14:08.65-07:00", "UserRole": null, "MarkedAsAnswerDate": null } ]