[ { "Id": "126709", "ThreadId": "38210", "Html": "
\r\nThe following is the message from yenyit:
\r\n
\r\nHi.  I'm doing some experiments with your DotNetZip component using an ASP.Net (2.x) page, and I'm getting an exception (Specified method is not supported) on the "zip.Save();" line.  The following is the source code of the test page:
\r\n
\r\n<%@ Page Language="C#" Debug="true" %>
\r\n<%@ Import Namespace="System.Text" %>
\r\n<%@ Import Namespace="System.IO" %>
\r\n<%@ Import Namespace="Ionic.Utils.Zip" %>
\r\n<%@ Import Namespace="System.Collections.Generic" %>
\r\n<script language="C#" runat="server">
\r\npublic void Page_Load (Object sender, EventArgs e)
\r\n{
\r\n Response.Clear();
\r\n String ReadmeText= "This is a zip file dynamically generated at " + System.DateTime.Now.ToString("G");
\r\n Response.ContentType = "application/zip";
\r\n Response.AddHeader("content-disposition", "filename=test.zip");
\r\n 
\r\n using (ZipFile zip = new ZipFile(Response.OutputStream)) {
\r\n   zip.AddFileFromString("Readme.txt", "", ReadmeText);
\r\n   zip.Save();
\r\n }
\r\n
\r\n Response.End();
\r\n}
\r\n</script>
\r\n
\r\n
\r\nCould you please let me know what I've done wrong?  Thanks.
\r\n", "PostedDate": "2008-10-21T16:55:06.867-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "126710", "ThreadId": "38210", "Html": "I suspect that the breaking line is the one that calls ZipFile.AddFileFromString() and not ZipFile.Save().   
\r\n
\r\nThere was a breaking change in DotNetZip in v1.6.   Originally the name of the method for adding content from a string was called "AddStringAsFile". I shipped some early DLLs with that method in it.   Later I thought this was misleading and non-intuitive.  I changed the method name to AddFileFromString(). 
\r\n
\r\nIs it possible that you have an older DLL for DotNetZip in the ASP.NET bin directory?   or in the GAC?
\r\n
\r\nIf your ASP.NET page is running against an older DLL, it would exhibit this problem.
\r\n
\r\n", "PostedDate": "2008-10-21T16:58:23.42-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "127032", "ThreadId": "38210", "Html": "Thanks for your reply.  I am quite certain that the page is not using an older version of the DotNetZip DLL.  If I change the "zip.AddFileFromString" line from the source code above to:
\r\n
\r\nzip.AddStringAsFile("Readme.txt", "", ReadmeText);
\r\n
\r\nthen I'll get a compiler error : 'Ionic.Utils.Zip.ZipFile' does not contain a definition for 'AddStringAsFile'
\r\n
\r\nAlso, if I change the "zip.AddFileFromString" line from the source code above to:
\r\n
\r\nzip.AddFile("c:\\\\inetpub\\\\testing\\\\www2\\\\test.txt");
\r\n
\r\nthen I'll get the "Specified method is not supported" exception on the "zip.Save();" line again as before.
\r\n", "PostedDate": "2008-10-22T13:50:30.34-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "127078", "ThreadId": "38210", "Html": "I am having the same issue with the 1.6 release.
\r\n
\r\nI just tried using the 1.5 dll and it works.
\r\n
\r\nFrom the debug output the error looks to be in a call to HttpResponseStream.get_Position()
\r\n", "PostedDate": "2008-10-22T17:44:06.73-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "127374", "ThreadId": "38210", "Html": "

Ah, thank you, that helps.

\r\n

Yes, this looks like a bug in the ZipFile.Save() method.  I have reproduced it here. Sorry about that.   My unit tests do not include an ASP.NET runtime test.
\r\n
\r\nLet me look into fixing it.

\r\n", "PostedDate": "2008-10-23T17:29:09.707-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "127382", "ThreadId": "38210", "Html": "This is fixed in change set 25482.  I also updated the binaries on the v1.6 release tab.  Thanks for reporting this.\r\n", "PostedDate": "2008-10-23T18:09:39.943-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "185957", "ThreadId": "38210", "Html": "I'm getting the same error with version 1.7.  I'm using a WCF web service method GetFileStream which returns a Stream object because the machine the web service is on is a DMZ.  Here is the code I'm using.  It crashes on the bold line.
\r\n
\r\n                Response.Clear();
\r\n                Response.ContentType = "application/zip";
\r\n                Response.AddHeader("content-disposition", "filename=Reports.zip");
\r\n                using (ZipFile zip = new ZipFile())
\r\n                {
\r\n                    foreach (string filepath in files_to_zip)
\r\n                    {
\r\n                        FileInfo file = new FileInfo(filepath);
\r\n                        Stream stream = mgsOps.GetFileStream(filepath);
\r\n                        zip.AddFileStream(file.Name, "", stream);
\r\n                    }
\r\n                    zip.Save(Response.OutputStream);
\r\n                }
\r\n                Response.End();
\r\n
\r\nIt's worth noting that before I moved the web service to the DMZ machine and could access files directly from the network, the bold line above worked successfully although I was creating the zip file a little differently.
\r\n", "PostedDate": "2009-05-01T11:26:13.21-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "186581", "ThreadId": "38210", "Html": "Mike, do you get a stacktrace?
\r\ncan you post it?
\r\n", "PostedDate": "2009-05-04T08:56:21.267-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "186592", "ThreadId": "38210", "Html": "Hi Cheeso,
\r\n
\r\nThanks for the reply.  Here is the stack trace:
\r\n
\r\n"   at System.ServiceModel.Dispatcher.StreamFormatter.MessageBodyStream.get_Length()\\r\\n   at Ionic.Zip.ZipEntry.FigureCompressionMethodForWriting(Int32 cycle)\\r\\n   at Ionic.Zip.ZipEntry.WriteHeader(Stream s, Int32 cycle)\\r\\n   at Ionic.Zip.ZipEntry.Write(Stream outstream)\\r\\n   at Ionic.Zip.ZipFile.Save()\\r\\n   at Ionic.Zip.ZipFile.Save(Stream outputStream)\\r\\n   at Reports.Download_click(Object sender, EventArgs e) in c:\\\\Inetpub\\\\wwwroot\\\\MGS2\\\\Reports.aspx.cs:line 300"
\r\n", "PostedDate": "2009-05-04T09:24:26.07-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "187864", "ThreadId": "38210", "Html": "Is there a possibility that the problem is in the zip.AddFileStream(file.Name, "", stream) line of code?  Could it be incorrectly creating the zip file causing it to be corrupt or something and the zip.Save(Response.OutuptStream) line has a problem with it?
\r\n", "PostedDate": "2009-05-07T13:16:27.48-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "187874", "ThreadId": "38210", "Html": "

Hmmm,
Based on what I am seeing, the problem is that while trying to create the zip file and save it to Response.OutputStream,  DotNetZip is getting an error while reading the Length property on the passed-in stream (which is, I guess, the result of the GetFileStream() ) call. 

\r\n

I still cannot tell what the error is.  Thanks for the stack trace; can you also provide the exact exception?  It could be a null pointer exception, or a method not supported exception, etc.  It's essential to know.

\r\n

Can you help me better understand what you are doing in the code?  Here is my guess: In the context of an ASP.NET page, you are calling out to a remote web service using WCF.   The response from WCF contains one or more attachments?   And you are then using GetFileStream() to get the files associated to those attachments. 

Are you certain that the stream in question returned from GetFileStream() is non-null? 

I think your instinct that the problem might be with AddFileFromStream() is correct.  IF there is a problem with the stream, it will fail during the call to Save(), which is when the ZipFile (or bytestream) is created.
If the stream you pass in to AddFileFromStream() is null, the exception will happen upon Save(). 
And if there are other problems with the Stream, for example if it does not support the Length property, it will also fail only upon Save().  

\r\n

Addendum: In v1.9, the ZipFile.AddFileFromString() method was renamed to ZipFile.AddEntry()

", "PostedDate": "2009-05-07T13:44:25.267-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "187882", "ThreadId": "38210", "Html": "Thanks for the response, Cheeso.  Your continued support of your product is truly appreciated.
\r\n
\r\nIt is a System.NotSupportedException: "Specified method is not supported."
\r\n
\r\nIt seems to get the stream successfully from the WCF service method.  When I check the Stream object, it is not null although some of the properties have a exceptions eg. Length    'stream.Length' threw an exception of type 'System.NotSupportedException'    long {System.NotSupportedException}.  When I check the Count property of the ZipFile object after I call the AddFileStream method, it does in fact increment. 
\r\n
\r\nIt seems then that the issue is how I'm creating the Stream object.  This is out of the scope of DotNetZip, but I'm wondering if you can tell me if there is anything wrong with the method I'm using:
\r\n
\r\n        public Stream GetFileStream(string filepath)
\r\n        {
\r\n            return File.OpenRead(filepath);
\r\n        }
\r\n
\r\n", "PostedDate": "2009-05-07T14:02:43.92-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "187930", "ThreadId": "38210", "Html": "

Geez, I don't know what to tell you. 

\r\n

I thought that GetFileStream() was a method on one of the WCF support classes, but your reply seems to indicate that GetFileStream() is something you wrote.  And furthermore it is very simple.

\r\n

What do you mean "it seems to get the stream successfully from the WCF service method" ?    I don't see where WCF is used at all.   I think I still don't understand what you are doing.

\r\n

Are you using ASP.NET and WCF in the same app?  Or are you saying that there are two separate apps, and in the first one, using WCF, you can successfully use DotNetZip, but in the second app, using ASP.NET, then you cannot successfully use DotNetZip. ????   I am guessing here.

\r\n

If I were debugging this I would check, wthin GetFileStream(), that I can read the file and get the Length and so on.  Try to separate it from any DotNetZip issues. 

\r\n

I don't see anything wrong with your method.  Could there be a permissions/security issue?   Also, for a stream returned in that way, you need to be sure to Dispose() it when you finish using it. 

\r\n

Taking one step back, I don't understand why you would use GetFileStream() and AddFileFromStream.  If GetFileStream just opens the file, why not just call ZipFile.AddFile() passing the name of the file - it seems simpler.

\r\n

 

\r\n

 

", "PostedDate": "2009-05-07T17:07:34.46-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "188103", "ThreadId": "38210", "Html": "

I have a WCF web service on one machine and a website that uses the WCF service on another machine.  The WCF accomplishes all of the "business" processing and just passes results required to load the page back to the website (on another machine).  I was originally using the following code - which works - to create the zip file:

\r\n

                Response.Clear();
                Response.ContentType = "application/zip";
                Response.AddHeader("content-disposition", "filename=Reports.zip");
                using (ZipFile zip = new ZipFile())
                {
                    foreach (string filepath in files_to_zip)
                    {
                        FileInfo myFile = new FileInfo(filepath);
                        zip.AddFile(myFile.FullName, "");
                    }
                    zip.Save(Response.OutputStream);
                }
                Response.End();

\r\n

This was in the testing/creation phase of the website, however.  It is ultimately going to be moved to another machine which is in a DMZ and does not have access to the network location where the files that I need to zip are located.  This is where the web service comes in.  I'm now trying to use the web service to pass a stream of data from the file to be zipped rather than the location of the file to be zipped so the website doesn't need direct access to the file.  This is why I'm trying now using AddFileStream() rather than AddFile().

\r\n

 

\r\n

I've altered my GetFileStream() method on the web service to be the following to help debugging:

\r\n

        public Stream GetFileStream(string filepath)
        {
            Stream stream = File.OpenRead(filepath);
            return stream;
        }

\r\n

When I step through it  in debug, stream.Length is defined when I try a file.  The value is of type long and has a value of 424448. 

\r\n

\"\"

\r\n

This is what I meant when I said "it seems to get the stream successfully from the WCF service method".  However, when I step further to see what the value of the Length property of the Stream object is on the website that I got back from the web service, there is an exception for the Length property.

\r\n

\"\"

\r\n

As another test, I decided to move the GetFileStream() to my web site just to rule out the web service being the issue.  To my amazement, when the Stream object was passed back from the GetFileStream() method, now on the same aspx page, to the zip for loop, it did have a valid Length property value.  As I continued to step through this time, the exception below occurred at the Response.End() line;

\r\n

{Unable to evaluate expression because the code is optimized or a native frame is on top of the call stack.}    System.Exception {System.Threading.ThreadAbortException}

\r\n

"   at System.Threading.Thread.AbortInternal()\\r\\n   at System.Threading.Thread.Abort(Object stateInfo)\\r\\n   at System.Web.HttpResponse.End()\\r\\n   at Reports.Download_click(Object sender, EventArgs e) in c:\\\\Inetpub\\\\wwwroot\\\\MGS2\\\\Reports.aspx.cs:line 303"

\r\n

HOWEVER, a prompt to save/open the zip file appeared and the zip file did contain the expected files!  The exception didn't stop the program so if you're not debugging, the program functions normally, correctly zipping the files.

\r\n

Thoughts?????????

", "PostedDate": "2009-05-08T06:19:18.007-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "188136", "ThreadId": "38210", "Html": "

OK, things are clearer now.

\r\n

As for the ThreadAbortException, I think that can occur when you have a debug session that exceeds the timeout value for the HTTP protocol.  If you are working in your debugger for a long time, the HTTP session can end, so Response.End() will fail, even though the response really did get all sent out.  So I wouldn't worry about that.

\r\n

On the NotSupportedException when trying to read the Length property - I see that MessageBodyStream (which is the type you get back from WCF) does not support Seek nor Length.  

\r\n

Thinking about it, DotNetZip should work with a non-seekable stream as input. It tries to get the length of the stream, but it shouldn't fail if that is not possible.  So I think this is a bug in DotNetZip.  If you don't mind I'd like to prepare a fix and ask you to test it.

\r\n

 

\r\n

 

\r\n

 

", "PostedDate": "2009-05-08T07:03:58.487-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "188138", "ThreadId": "38210", "Html": "This discussion has been copied to a work item. Click here to go to the work item and continue the discussion.", "PostedDate": "2009-05-08T07:05:53.28-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "188147", "ThreadId": "38210", "Html": "

To get the fix, I'd like you to try out either v1.8.3.1, or v1.7.2.18. 

\r\n

 

", "PostedDate": "2009-05-08T07:43:18.433-07:00", "UserRole": null, "MarkedAsAnswerDate": null } ]