[
{
"Id": "141904",
"ThreadId": "42704",
"Html": "I have compressed a lot of files using an older version of DotNet Zip library. Now I have updated at version 1.6 and when i try to unzip some files created using the older version, sometime I have an error: not a valid zip file. If I open these files using winzip or unzip these folders in Window XP I have no problem... they seem to be valid.
\r\nI have downloaded the source code and I have noticed that the problem is in the static method PackedToDateTime of the internal class SharedUtilities, namespace Ionic.Utils.Zip.
\r\nFor these not valid zip files, the second value calculated by this function is 60 so when the function try to create a new datetime value ( new System.DateTime(year, month, day, hour, minute, second, 0)) I have a System.ArgumentOutOfRangeException.
\r\nProbably, in the older version, this is ignored and in this case then function retun System.DateTime.Now.
\r\n
\r\n internal
\r\n static DateTime PackedToDateTime(Int32 packedDateTime)
\r\n {
\r\n Int16 packedTime = (Int16)(packedDateTime & 0x0000ffff);
\r\n Int16 packedDate = (Int16)((packedDateTime & 0xffff0000) >> 16);
\r\n int year = 1980 + ((packedDate & 0xFE00) >> 9);
\r\n int month = (packedDate & 0x01E0) >> 5;
\r\n int day = packedDate & 0x001F;
\r\n int hour = (packedTime & 0xF800) >> 11;
\r\n int minute = (packedTime & 0x07E0) >> 5;
\r\n //int second = packedTime & 0x001F;
\r\n int second = (packedTime & 0x001F) * 2;
\r\n DateTime d = System.DateTime.Now;
\r\n try { d = new System.DateTime(year, month, day, hour, minute, second, 0); }
\r\n catch (System.ArgumentOutOfRangeException ex1)
\r\n {
\r\n throw new ZipException("Bad date/time format in the zip file.", ex1);
\r\n //Console.WriteLine("exception formatting the date: {0}\\n\\n", ex1.ToString());
\r\n //Console.Write("\\nInvalid date/time?:\\nyear: {0} ", year);
\r\n //Console.Write("month: {0} ", month);
\r\n //Console.WriteLine("day: {0} ", day);
\r\n //Console.WriteLine("HH:MM:SS= {0}:{1}:{2}", hour, minute, second);
\r\n }
\r\n return d;
\r\n }
\r\n
\r\nWhy is the header date so important to throw new ZipException?
\r\n",
"PostedDate": "2008-12-19T09:56:39.247-08:00",
"UserRole": null,
"MarkedAsAnswerDate": null
},
{
"Id": "141913",
"ThreadId": "42704",
"Html": "yes -
\r\nin v1.6, I added logic to set the timestamp on files as they are being unpacked.
\r\nthis means that older zip files with potentially out-of-range values for the timestamp will cause the new library to choke.
\r\n\r\nyou can add this to the PackedToDateTime method:
\r\n\r\n
// validation and error checking.\r\n// this is not foolproof but will catch most errors.\r\nif (second >= 60) {minute++; second=0;}\r\nif (minute >= 60) {hour++; minute=0;}\r\nif (hour >= 24) { day++; hour = 0; }\r\n\r\nDateTime d = System.DateTime.Now;\r\ntry { d = new System.DateTime(year, month, day, hour, minute, second, 0); }\r\n\r\n\r\n
or wait just a bit and I will back-port this fix to v1.6.
\r\n\r\n\r\n",
"PostedDate": "2008-12-19T10:19:08.98-08:00",
"UserRole": null,
"MarkedAsAnswerDate": null
},
{
"Id": "141916",
"ThreadId": "42704",
"Html": "thank you for reply and sorry for my bad english
\r\nI hope you fix it relatively soon.
\r\n
\r\nBye.
\r\n
\r\n",
"PostedDate": "2008-12-19T10:32:53.733-08:00",
"UserRole": null,
"MarkedAsAnswerDate": null
},
{
"Id": "141926",
"ThreadId": "42704",
"Html": "Ok, the validation of date/time is now available in the v1.6.3.15 release. \r\n",
"PostedDate": "2008-12-19T11:20:14.953-08:00",
"UserRole": null,
"MarkedAsAnswerDate": null
},
{
"Id": "151403",
"ThreadId": "42704",
"Html": "similar problem with v1.6.3.18 of the dll.ReadHeader can't seem to understand the block.
ze._VersionNeeded = 20
ze._BitField = 2
ze._CompressionMethod = 8
ze._TimeBlob = -1
here are the block bytes.
-\t\tblock\t{Dimensions:[26]}\tbyte[]
\t\t[0]\t20\tbyte
\t\t[1]\t0\tbyte
\t\t[2]\t2\tbyte
\t\t[3]\t0\tbyte
\t\t[4]\t8\tbyte
\t\t[5]\t0\tbyte
\t\t[6]\t255\tbyte
\t\t[7]\t255\tbyte
\t\t[8]\t255\tbyte
\t\t[9]\t255\tbyte
\t\t[10]\t148\tbyte
\t\t[11]\t98\tbyte
\t\t[12]\t208\tbyte
\t\t[13]\t121\tbyte
\t\t[14]\t144\tbyte
\t\t[15]\t23\tbyte
\t\t[16]\t0\tbyte
\t\t[17]\t0\tbyte
\t\t[18]\t164\tbyte
\t\t[19]\t86\tbyte
\t\t[20]\t0\tbyte
\t\t[21]\t0\tbyte
\t\t[22]\t10\tbyte
\t\t[23]\t0\tbyte
\t\t[24]\t0\tbyte
\t\t[25]\t0\tbyte
the timestamp on the file is 1/13/2009 11:18am
any thoughts?
thx.
s.
\r\nAre you saying you have such a zip archive?
\r\nhow did you produce it? With what tool?
\r\n
\r\nWhen you extract the file with winzip or unixutils, does it get the timestamp you mentioned (1/13/2009, etc) ?
\r\n
\r\nIt shouldn't be difficult to insert some logic to handle the case where the timestamp is 0xFFFFFFFF. But it would go into the v1.7 library, as v1.6 is already final.
\r\n
\r\nIf this is what you want, please file a workitem and upload the zip archive.
\r\n",
"PostedDate": "2009-02-02T11:23:42.7-08:00",
"UserRole": null,
"MarkedAsAnswerDate": null
},
{
"Id": "156894",
"ThreadId": "42704",
"Html": "This discussion has been copied to a work item. Click here to go to the work item and continue the discussion.",
"PostedDate": "2009-02-11T21:45:38.343-08:00",
"UserRole": null,
"MarkedAsAnswerDate": null
},
{
"Id": "251328",
"ThreadId": "42704",
"Html": "I usually use for work with zip files different tools.But once some important zip archives were damaged.And no one of these tools couldn't help me.And a friend recommended to me-corrupt zip files recovery software.Software solved my problem easy and for free.
",
"PostedDate": "2009-10-29T12:29:03.563-07:00",
"UserRole": null,
"MarkedAsAnswerDate": null
}
]