[ { "Id": "148704", "ThreadId": "44663", "Html": "Hi @all!
\r\nI'm using this nice ZipDll in my software and I have a problem with "UpdateFileStream" depending on how fast the target computer is.
\r\nWhat I want to do: Unzip a file from the Zip Archive by loading it into MemoryStream -> change this XML-File -> Update the Zip-File (the file inside the Zip-Archive) with the new MemoryStream.
\r\n
\r\nHere's my code:
\r\n\r\n

myZip =

\r\n\r\n

new ZipFile(sFileName);
\r\nmyZip.Password = Program.sZipPW;
\r\nMemoryStream machineDataStream = new MemoryStream();
\r\nstring sInnerFileToLoadAsDataTable = "tblMachineData.xml";
\r\nstring sFolderName = PLC_Fill_Methods.getFolderNameInZip(sFileName); // This method only checks if there is a folder inside the archive and if, what is its name - unimportant
\r\nmyZip.Extract(sFolderName + sInnerFileToLoadAsDataTable, machineDataStream);
\r\n
\r\n// These two lines are new but didn't solve the problem
\r\nmyZip.Dispose();
\r\nmyZip = null;\r\n

 

\r\n

\r\n

 

\r\n

XmlDocument x_doc = new XmlDocument();
\r\nmachineDataStream.Seek(0, SeekOrigin.Begin);
\r\nx_doc.Load(machineDataStream);
\r\nmachineDataStream.Dispose();
\r\nmachineDataStream = null;

\r\n

 

\r\n

//update the XML File
\r\nXmlNode x_nodeToChange = x_doc.SelectSingleNode("NewDataSet/tblMachineData[ParameterId = '" + sParamId + "']");
\r\nif (x_nodeToChange != null)
\r\n{
\r\nXmlNode x_ParamNode = x_nodeToChange.SelectSingleNode("Value");
\r\nx_ParamNode.InnerText = sValue;
\r\n}

\r\n

 

\r\n

MemoryStream newMachineDataStream = new MemoryStream();
\r\nx_doc.Save(newMachineDataStream);
\r\nnewMachineDataStream.Seek(0, SeekOrigin.Begin);\r\n

myZip =

\r\n

\r\n

new ZipFile(sKpdFilePath); // these two lines are also new but didn't solve the problem
\r\nmyZip.Password = Program.sZipPW;\r\n

 

\r\n

 

\r\n

myZip.UpdateFileStream(

\r\n

\r\n

"tblMachineData.xml", sFolderName, newMachineDataStream);\r\n

 

\r\n

 

\r\n

\r\n

 

\r\n\r\n

myZip.Save(); // here I will get the exception; not in Visual Studio or on a Pentium 4 but on fatser PCs like Core2Duo I get "The process cannot access the file "..." because it is being used by another process

\r\n

newMachineDataStream.Dispose();
\r\nnewMachineDataStream =

\r\n\r\n

null;
\r\nmyZip.Dispose();
\r\nmyZip = null;
\r\n
\r\nWhat else can I do to manage my problem??? Any idea???\r\n

 

\r\n

\r\n

 

\r\n\r\n", "PostedDate": "2009-01-20T05:12:56.317-08:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "148733", "ThreadId": "44663", "Html": "Nobody with an idea??? Is there an yway to set the fileaccess free? Has such a issue never been tested, I can't believe! Please help!
\r\nMaybe I open the file for reading in a false way. But if so, are there other ways to open it??? \r\n", "PostedDate": "2009-01-20T06:52:30.35-08:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "149298", "ThreadId": "44663", "Html": "Jochen, gimme some time to have a look. . .\r\n", "PostedDate": "2009-01-21T08:41:33.833-08:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "149342", "ThreadId": "44663", "Html": "I tried your general code - it worked for me, but I don't have a fast PC.
\r\n
\r\nIt's possible that there is a stream that is remaining open inadvertently after the call to x_doc.Save() . 
\r\nCould you please try to insert a the following lines into your code following the x_doc.Save() and before the myZip.Save()  ??
\r\n
\r\nx_doc = null;
\r\nGC.Collect();
\r\n
\r\nHere is my example:
\r\n
\r\n
        private void ModifyFileWithinZip()\r\n        {\r\n            using (var zip = ZipFile.Read(zipFileName))\r\n            {\r\n                XmlDocument doc = new XmlDocument();\r\n                using (MemoryStream machineDataStream = new MemoryStream())\r\n                {\r\n                    zip.Extract(xmlFileName, machineDataStream);\r\n\r\n                    machineDataStream.Seek(0, SeekOrigin.Begin);\r\n                    doc.Load(machineDataStream);\r\n                }\r\n\r\n \r\n                //update the XML File\r\n                XmlNode node = doc.SelectSingleNode(xpath);\r\n\r\n                if (node != null)\r\n                {\r\n                    Console.WriteLine("Node xpath: {0}", xpath);\r\n                    Console.WriteLine("current value: {0}", node.InnerText);\r\n                    Console.WriteLine("new value: {0}", newvalue);\r\n                    node.InnerText = newvalue;\r\n\r\n                    using (MemoryStream newMachineDataStream = new MemoryStream())\r\n                    {\r\n                        doc.Save(newMachineDataStream);\r\n\r\n                        // try this to close out any inadvertently open streams:\r\n                        doc= null;\r\n                        GC.Collect();\r\n\r\n                        newMachineDataStream.Seek(0, SeekOrigin.Begin); \r\n\r\n                        zip.UpdateFileStream(xmlFileName, "", newMachineDataStream); \r\n\r\n                        // Here I will get the exception; not in Visual Studio or on a\r\n                        // Pentium 4 but on faster PCs like Core2Duo I get "The process\r\n                        // cannot access the file "..." because it is being used by\r\n                        // another process.\r\n\r\n                        zip.Save();\r\n                    }\r\n\r\n                }\r\n            }\r\n        }\r\n\r\n
\r\n", "PostedDate": "2009-01-21T09:58:07.857-08:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "570232", "ThreadId": "44663", "Html": "

Hey guys, especially Cheeso; long time lurker here, finally had to post:

\n

I would like to confirm the same behavior. You fix DOES help, but I am a little iffy about the reason and the fix approach. Specifically, there are cases where this explicit GC.Collect() call may not help.

\n

What I do not understand is why we need to kill off XMLDocument. I checked the docs and yes, XMLDocument does not have IDispose interfaces (no using) and no explicit .Close() either. The reason as far as I can see it that the XMLDocument is just a memory struct, so why after .Save() is called on MemoryStream do we fail in .Save(ing) the zip file? Would it help to copy the stream into a new stream and then write *that* stream into the archive?

\n

Oh and PS. UpdateEntry does not take full path like AddEntry does :( Or, it is somewhat confusing. AddEntry(\"\\\\path\\\\filename.txt\") fails if entry is present but UpdateEntry(\"\\\\path\\\\filename.txt\") just places the file in root :)

\n

 

\n

P.P.S. Thank you for your dedication and amazing work. Setup a donation page or something, I would most definitely drop some for you!

", "PostedDate": "2011-02-22T08:26:34.687-08:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "571210", "ThreadId": "44663", "Html": "

Kommi - not sure about this old story.

\r\n

I don't usually recommend GC.Collect(), ever, but this was a diagnostic and troubleshooting thing.

\r\n

If you're having a problem I suggest you open a new thread to cover it.  This one is more than 2 years old, and surely is dealing with an older version of the library.

\r\n

Also - regarding donations - there is a donation page.  Not sure how you missed it!

\r\n

http://cheeso.members.winisp.net/DotNetZipDonate.aspx

", "PostedDate": "2011-02-23T18:05:42.86-08:00", "UserRole": null, "MarkedAsAnswerDate": null } ]