[ { "Id": "165527", "ThreadId": "49468", "Html": "For example, how can you exclude "*.pst" files?   I was thinking there would be a zip.addDirectory(source, filestoexclude) kind of thing..\r\n
\r\n", "PostedDate": "2009-03-06T14:50:12.94-08:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "165528", "ThreadId": "49468", "Html": "The current method signature is:
\r\n
\r\nZipFile.AddSelectedFiles("name != *.pst", MyDirectory, True)
\r\n
\r\nTrue  means "recurse directories".
\r\n
\r\nDoes it make sense to reverse the Directory and the selection criteria string?  
\r\nDoes it make sense to default the recurse directories behavior to "true" ?
\r\n", "PostedDate": "2009-03-06T14:51:55.947-08:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "165607", "ThreadId": "49468", "Html": "Hi Cheeso,
\r\n
\r\nYes it make sense to reverse source and selection, for the recursive bool is less evident.\r\n", "PostedDate": "2009-03-06T23:17:13.92-08:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "165840", "ThreadId": "49468", "Html": "Hey Dom, thanks for the feedback.  I'm looking at that method, and I feel like it could go either way.
\r\n
\r\nTo keep similarity with the existing AddDirectory() method, the order of params should be AddSelectedFiles(directoryPath, selectionCriteria).
\r\nTo keep similarity with the AddSelectedFiles() method, the order of params should be AddSelectedFiles(selectionCriteria, directoryPath).
\r\n
\r\nTo address this, I may add a new overload for AddDirectory(), and specify 
\r\nAddDirectory(directoryPath, selectionCriteria).  (with recursion always true).
\r\nBut the problem there is, there is already an AddDirectory(String, String) = the second string is the directory path to use in the archive. \r\n", "PostedDate": "2009-03-08T12:33:55.143-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "166073", "ThreadId": "49468", "Html": "Using 1.8.1.15 -
\r\nI tried the ZipFile.AddSelectedFiles("name != *.pst", SourceDirectory, True) but it did not zip all the files or subdirectories within the SourceDirectory.
\r\nIt did not error, just my expectation was that it would zip all files and subdirectories as before, yet exclude any .pst files.
\r\nYou mentioned above you might try to add a new overload to AddDirectory. When you do, I'll be happy to test.
\r\nQuestion though, when you say selectionCriteria, does that mean to include or exclude? Or both depending on syntax?\r\n", "PostedDate": "2009-03-09T07:12:16.677-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "166182", "ThreadId": "49468", "Html": "On the AddSelectedFiles thing -
\r\n
\r\nAddSelectedFiles("name != *.pst", SourceDir, True) is expected to add all the files in SourceDir or any child directory, that are  not pst files (not ending in .pst as an extension) into the zip file. 
\r\nYou said it didn't behave as you expected.  What did it do?  Which files or folders were not included, that you thought should be included?
\r\n
\r\nI found a glitch in the FileSelector, and fixed it, just this morning.  but I'm not sure it's the same problem you are running into here.
\r\nThe problem I found was that the match was failing if a filename contained more than one dot.  Like Form1.Designer.vb would not match "*.*"    I've fixed that, I think.
\r\nWhat did YOU see?
\r\n
\r\nI also noticed a problem in the example code in the doc - I had omitted a call to zip.Save after adding the files!!  whoops.
\r\n
\r\n
\r\n", "PostedDate": "2009-03-09T11:01:18.327-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "166192", "ThreadId": "49468", "Html": "I basically took this code in my program:
\r\n            zipArchive.AddDirectory(SourceFolder)
\r\n            zipArchive.CompressionLevel = Zlib.CompressionLevel.LEVEL9_BEST_COMPRESSION
\r\n            zipArchive.UseZip64WhenSaving = Ionic.Zip.Zip64Option.Always
\r\n            zipArchive.TempFileFolder = txtFolderSave.Text
\r\n            zipArchive.Save(DestFile)
\r\n
\r\nChange it to:
\r\n            zipArchive.AddSelectedFiles("name != *.pst", SourceDir, True)
\r\n            zipArchive.CompressionLevel = Zlib.CompressionLevel.LEVEL9_BEST_COMPRESSION
\r\n            zipArchive.UseZip64WhenSaving = Ionic.Zip.Zip64Option.Always
\r\n            zipArchive.TempFileFolder = txtFolderSave.Text
\r\n            zipArchive.Save(DestFile)
\r\n
\r\nIt zipped with out error, but when I opened the zip file there were a lot of files/subdirectories missing. So many I just reverted back to the AddDirectory method (because I was working on other stuff - didn't have time to dig deeper).
\r\nExample directory folder structure (assume many more sub dirs with files in each)-
\r\nMy Docs
\r\nMy Docs\\ABC
\r\nMy Docs\\XYZ
\r\nMy Docs\\VB2005
\r\n
\r\nAfter zipping, the one folder in particular I noticed was the VB2005 folder (which contains 8 subdirs under VB2005 (many many more folders and file under those 8)); nothing was there. The VB2005 folder was there, but nothing else - 1 file I think. This might not help you much I know, so I'll try to test more soon.
\r\nBut that's what happened.
\r\n
\r\n", "PostedDate": "2009-03-09T11:21:33.597-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "166224", "ThreadId": "49468", "Html": "Thank you, I will look further.\r\n", "PostedDate": "2009-03-09T12:39:03.327-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "166233", "ThreadId": "49468", "Html": "Jeff, you found a bug.
\r\nI just fixed it.   It was a one-line thing.  The code was ignoring the recurseDirectories parameter.
\r\nv1.8.1.19 has the correction.  Please try it out.
\r\nlet me know.
\r\n", "PostedDate": "2009-03-09T13:03:59.193-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "168539", "ThreadId": "49468", "Html": "Sorry for the delay in this test...
\r\nIt worked fine and recursed thru the directories.
\r\nCouple of questions though when you have a moment.
\r\nWhen zipping the My Documents directory, upon opening the zip archive, I noticed it contained the whole path from the root. In this case, Users\\jeffy\\Documents\\. The AddDirectory doesn't do this, I assume because of the nature it which it recurses thru the directory.
\r\n
\r\nUsing AddSelectedFiles("name != *.pst", SourceDir, True):
\r\nIs there a way to eliminate the preceding path to the directory being zipped?
\r\nIs there a way to exclude more than one file? In example (and i'm guessing): AddSelectedFiles("name != *.pst | name != *.doc", SourceDir, True)
\r\nIf there were no exclusions, could I keep the same method syntax and put in some sort of null for the exclusion parameter?
\r\n
\r\nI want to build in some sort of selectable exclusions GUI for the user. So I need to code it in such a way, roughly speaking, that it is like:
\r\n
\r\nDim selection1 as string 'user exclusion selection 1
\r\nDim selection2 as string 'user exclusion selection 2
\r\nDim exclusion as string="name != " & selection1
\r\ncode..
\r\ncode..
\r\ncode..
\r\nAddSelectedFiles(exclusion, SourceDir, True)
\r\n
\r\nWhere exclusion could be null, could have 1 string value, 2 values, etc.
\r\nThat is real rough code just shooting from the hip (I haven't done anything yet), but you get the idea (I hope).
\r\n
\r\nYour thoughts?
\r\n
\r\n
\r\n
\r\n
\r\n
\r\n
\r\n
\r\n
\r\n\r\n", "PostedDate": "2009-03-16T07:34:38.527-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "170481", "ThreadId": "49468", "Html": "

Hi Jeff!
\r\n
\r\nAbout compound selection criteria -
\r\nYou would use something like this:   (name != *.pst  AND  name != *.doc)
\r\nI tried to document this in the help file. 
\r\nhttp://cheeso.members.winisp.net/DotNetZipHelp/html/4469abe7-8fa4-101e-975d-305d2fd0affb.htm

\r\n

About the whole path from the root -
\r\nThere is an overload of ZipFile.AddSelectedFiles() that allows you to specify the directory in the archive. 

\r\n

With the overload, you can, for example, do

\r\n
  ZipFile.AddSelectedFiles("name != *.pst", "c:\\My Docs\\Local", "archive", true) \r\n
\r\n

This will add all the files in c:\\my docs\\local into the zip archive, but will use "archive" as the root directory in the archive. You will have to test it out to see what I mean. 

\r\n

One last thing:: thanks for confirming that the changes worked as advertised.  If you have NEW questions, I'd appreciate it if you could open a new thread. It makes it nicer for search and it makes it easier for other people to benefit from the Q&A.
\r\nthanks!

\r\n", "PostedDate": "2009-03-21T22:32:54.557-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "173235", "ThreadId": "49468", "Html": "Hello, my name's Alessandro.
\r\nI'm using DotNetZip 1.8.2.3 but I have some problems with the AddSelectedFiles Method when I try to zip a folder with the necessity of exclusion some files.
\r\nFor example, I tried to zip the Mozilla Profile Folder:
\r\n
\r\nZipFile _zip = new ZipFile();
\r\n_zip.AddSelectedFiles("name != parent.lock and name != places.sqlite-journal", _profilePath, "Mozilla", true);
\r\n_zip.Save(_nameOfZipFile);
\r\n
\r\nIt makes the zip file but the files contained in the zip file lose the tree of the original folder.
\r\n
\r\nI found this problem with the AddFile Method too.
\r\n
\r\nThis is my code:
\r\nstring[] _tempArray = Directory.GetFiles(_profilePath, "*.*", SearchOption.AllDirectories);
\r\nint i = -1;
\r\n foreach (string _entryToAdd in _tempArray)
\r\n{
\r\n    i++;
\r\n    if (!(_entryToAdd.Contains("parent.lock")) & !(_entryToAdd.Contains("places.sqlite-journal")))
\r\n    {
\r\n          _zip.AddFile(_entryToAdd,"Mozilla");
\r\n    }
\r\n
\r\n}
\r\n_zip.Save(_nameOfZipFile);
\r\n
\r\nSame problem: lose the tree of original folder :-(
\r\nI tried with 1.7 branch too.
\r\nCan you help me?
\r\nMany thanks!
\r\nRegards,
\r\nAlessandro.
\r\n
\r\n", "PostedDate": "2009-03-29T10:32:22.2-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "173247", "ThreadId": "49468", "Html": "The behavior with AddSelectedFiles sure looks like a basic bug. I've opened a workitem.
\r\n
\r\nThe behavior with AddFile is expected and documented.  With AddFile(), you are specifying the name of a file on disk, and the name of a directory in the archive.  The name of the dir in the archive is always "Mozilla", which means you "flatten" the directory hierarchy.  Using AddFile(), to reproduce the hierarchy of the directory tree on disk, in the zip archive, you would have to append the dir path to "Mozilla".  eg something like
\r\n
\r\n
_zip.AddFile(_nameOfFileToAdd, Path.Combine("Mozilla",Path.GetDirectoryName(_nameOfFileToAdd.Replace(_profilePath, ""))));\r\n
\r\nYou can also get the directory tree if you call the AddFiles() method:
\r\n
\r\n
        Ionic.FileSelector ff = new Ionic.FileSelector(selectionCriteria);\r\n        var filesToAdd = ff.SelectFiles(_directoryToZip, recurseDirectories);\r\n        using (ZipFile _zip = new ZipFile())\r\n        {\r\n            _zip.AddFiles(filesToAdd);\r\n            _zip.Save(_nameOfZipFile);\r\n        }\r\n
\r\nBut, this does not allow you to specify the top-level directory to use in the zip, a la "Mozilla". \r\n", "PostedDate": "2009-03-29T11:50:49.537-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "173248", "ThreadId": "49468", "Html": "This discussion has been copied to a work item. Click here to go to the work item and continue the discussion.", "PostedDate": "2009-03-29T11:51:35.417-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "173261", "ThreadId": "49468", "Html": "Alessandro, the problem is fixed in v1.8.2.5. \r\n", "PostedDate": "2009-03-29T13:15:05.947-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "173264", "ThreadId": "49468", "Html": "I tried in this moment but now there is another problem with the AddSelectedFiles method: in the zip file there is the complete tree path of the original folder.
\r\nIn my case "Users\\Administrator\\AppData\\Roaming\\Mozilla\\".
\r\nIt seems that the string directoryPathInArchve value passed to the method is not working. :-(
\r\n", "PostedDate": "2009-03-29T13:38:56.75-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "173265", "ThreadId": "49468", "Html": "Thanks for your work however ;-)
\r\nI hope you fix this problem in the future.
\r\n", "PostedDate": "2009-03-29T13:40:11.647-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "173270", "ThreadId": "49468", "Html": "Yes, I see.  Thanks for working through this with me. 
\r\nCan you try v1.8.2.7 ?
\r\n
\r\n", "PostedDate": "2009-03-29T14:28:50.337-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "173272", "ThreadId": "49468", "Html": "Well done, Cheeso! Now it's working!
\r\nMany thanks!
\r\n
\r\n
\r\n", "PostedDate": "2009-03-29T14:44:55.32-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "173273", "ThreadId": "49468", "Html": "The 1.8.2.7 version has been fixed this bug ;-)
\r\nCongratulations!
\r\n", "PostedDate": "2009-03-29T14:48:11.677-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "173281", "ThreadId": "49468", "Html": "Thanks, Alessandro, for reporting it and working through it with me.  \r\n", "PostedDate": "2009-03-29T15:32:52.633-07:00", "UserRole": null, "MarkedAsAnswerDate": null } ]