[ { "Id": "184711", "ThreadId": "54769", "Html": "Here's my problem,
\r\n
\r\nI created a static class (ZipUtil.cs) which has a bunch of methods which call DotNetLib and create an archive, update an archive, delete a file in the archive etc.
\r\nThe archive that is created when I call the static class throws the error "Could not read signature - no data!  (position 0x00005601)" when I tried to add a file using the static class.
\r\nBut when I take the same code that is in the static class and put it directly in my main method (the commented stuff in Program.cs), the archive created works just fine when I try to add a file using the static class.
\r\n
\r\nHere are my two files.
\r\n
\r\n

Program.cs

\r\n

\r\n

\r\n


\r\nusing System;
\r\nusing Cps.Utility.CompressionUtils;
\r\nusing Ionic.Zip;
\r\n
\r\nnamespace Cps.Utility
\r\n{
\r\nclass Program
\r\n{
\r\nstatic void Main(string[] args)
\r\n{
\r\n//string dirname = @"c:\\tmp\\dir1";
\r\n//string dir1 = "dir1";
\r\n//using (ZipFile zip = new ZipFile(dirname + ".zip"))
\r\n//{
\r\n// //zip.AddDirectory(@"c:\\tmp\\dir1", "dir1");
\r\n// zip.AddDirectory(dirname, dir1);
\r\n// zip.Save();
\r\n//}
\r\nif ("create".Equals(args[0], StringComparison.CurrentCultureIgnoreCase))
\r\n{
\r\nConsole.WriteLine("Extracting Archive");
\r\nZipUtil.createArchive(@"c:\\tmp\\dir1");
\r\nreturn;
\r\n}
\r\nif ("extract".Equals(args[0], StringComparison.CurrentCultureIgnoreCase))
\r\n{
\r\nZipUtil.extractArchive(@"c:\\tmp\\dir1.zip", @"c:\\tmp\\dotnetzip\\");
\r\nreturn;
\r\n}
\r\nif ("add".Equals(args[0], StringComparison.CurrentCultureIgnoreCase))
\r\n{
\r\nZipUtil.addFileToArchive("c:\\\\tmp\\\\crap.txt", "dir1\\\\dir12", "c:\\\\tmp\\\\dir1.zip");
\r\nreturn;
\r\n}
\r\nif ("delete".Equals(args[0], StringComparison.CurrentCultureIgnoreCase))
\r\n{
\r\nZipUtil.removeFileFromArchive(@"dir\\dir12\\crap.txt", @"c:\\tmp\\dir1.zip");
\r\nreturn;
\r\n}
\r\nif ("replace".Equals(args[0], StringComparison.CurrentCultureIgnoreCase))
\r\n{
\r\nZipUtil.updateFileInArchive(args[1], args[2], args[3]);
\r\nreturn;
\r\n}
\r\nif ("move".Equals(args[0], StringComparison.CurrentCultureIgnoreCase))
\r\n{
\r\nZipUtil.moveFileInArchive(args[1], args[2], args[3], args[4]);
\r\nreturn;
\r\n}
\r\nthrow new NotImplementedException();
\r\n}
\r\n}
\r\n}
\r\n
\r\nZipUtil.cs
\r\n
\r\nusing System;
\r\nusing System.IO;
\r\nusing Ionic.Zip;
\r\n
\r\nnamespace Cps.Utility.CompressionUtils
\r\n{
\r\npublic class ZipUtil
\r\n{
\r\npublic static void createArchive(string directoryPath)
\r\n{
\r\nif (Directory.Exists(directoryPath) == false)
\r\nthrow new DirectoryNotFoundException();
\r\n
\r\nusing(ZipFile zip = new ZipFile(directoryPath+".zip"))
\r\n{
\r\nzip.AddDirectory(directoryPath, (new DirectoryInfo(directoryPath)).Name);
\r\nzip.Comment = "This zip was created at " + DateTime.Now.ToString("G") ;
\r\nzip.Save();
\r\n}
\r\n}
\r\n
\r\npublic static void addFileToArchive(string filePath, string relativePathInArchive, string zipArchivePath)
\r\n{
\r\nif (File.Exists(zipArchivePath) == false)
\r\nthrow new FileNotFoundException("File Not Found", zipArchivePath);
\r\n//if (ZipFile.IsZipFile(zipArchivePath) == false)
\r\n// throw new FileLoadException("Specified archive not a zip file");
\r\nif (File.Exists(filePath) == false)
\r\nthrow new FileNotFoundException("File Not Found", filePath);
\r\n
\r\nusing (ZipFile zip = ZipFile.Read(zipArchivePath))
\r\n{
\r\nzip.AddFile(filePath, relativePathInArchive);
\r\nzip.Comment = "This zip archive was updated " + DateTime.Now.ToString("G");
\r\nzip.Save(zipArchivePath);
\r\n}
\r\n}
\r\n
\r\npublic static void removeFileFromArchive(string relativePathInArchive, string zipArchivePath)
\r\n{
\r\nif (File.Exists(zipArchivePath) == false)
\r\nthrow new FileNotFoundException("File Not Found", zipArchivePath);
\r\nif (ZipFile.IsZipFile(zipArchivePath) == false)
\r\nthrow new FileLoadException("Specified archive not a zip file");
\r\n
\r\nusing (ZipFile zip = ZipFile.Read(zipArchivePath))
\r\n{
\r\nZipEntry e = zip[relativePathInArchive];
\r\n
\r\nif (e == null)
\r\nthrow new FileNotFoundException("File not found in archive", relativePathInArchive);
\r\n
\r\nzip.RemoveEntry(relativePathInArchive);
\r\nzip.Comment = "This zip archive was updated " + DateTime.Now.ToString("G");
\r\nzip.Save();
\r\n}
\r\n}
\r\n
\r\npublic static void updateFileInArchive(string filePath, string relativePathInArchive, string zipArchivePath)
\r\n{
\r\nif (File.Exists(zipArchivePath) == false)
\r\nthrow new FileNotFoundException("File Not Found", zipArchivePath);
\r\nif (ZipFile.IsZipFile(zipArchivePath) == false)
\r\nthrow new FileLoadException("Specified archive not a zip file");
\r\nif (File.Exists(filePath) == false)
\r\nthrow new FileNotFoundException("File Not Found", filePath);
\r\n
\r\nusing (ZipFile zip = ZipFile.Read(zipArchivePath))
\r\n{
\r\n// for this entry, update the archive with content from the filesystem
\r\nZipEntry e = zip[relativePathInArchive];
\r\n
\r\nif (e == null)
\r\nthrow new FileNotFoundException("File not found in archive", relativePathInArchive);
\r\n
\r\nzip.UpdateItem(filePath);
\r\nzip.Comment = "This zip archive was updated " + DateTime.Now.ToString("G");
\r\nzip.Save();
\r\n}
\r\n}
\r\n
\r\npublic static void moveFileInArchive(string fileName, string filePathInArchive, string destFolderInArchive,
\r\nstring zipArchivePath)
\r\n{
\r\nif (File.Exists(zipArchivePath) == false)
\r\nthrow new FileNotFoundException("File Not Found", zipArchivePath);
\r\nif (ZipFile.IsZipFile(zipArchivePath) == false)
\r\nthrow new FileLoadException("Specified archive not a zip file");
\r\n
\r\nusing (ZipFile zip = ZipFile.Read(zipArchivePath))
\r\n{
\r\nZipEntry e = zip[filePathInArchive + fileName];
\r\n
\r\nif (e == null)
\r\nthrow new FileNotFoundException("File not found in archive", filePathInArchive);
\r\n
\r\ne.FileName = destFolderInArchive + filePathInArchive;
\r\nzip.Comment = "This zip archive was updated " + DateTime.Now.ToString("G");
\r\nzip.Save();
\r\n}
\r\n}
\r\n
\r\npublic static void extractArchive(string zipArchivePath, string destinationFolder)
\r\n{
\r\nif (File.Exists(zipArchivePath) == false)
\r\nthrow new FileNotFoundException("File Not Found", zipArchivePath);
\r\nif (ZipFile.IsZipFile(zipArchivePath) == false)
\r\nthrow new FileLoadException("Specified archive not a zip file");
\r\n
\r\nusing (ZipFile zip = ZipFile.Read(zipArchivePath))
\r\n{
\r\nforeach (ZipEntry e in zip)
\r\n{
\r\ne.Extract(destinationFolder, true); // overwrite == true
\r\n}
\r\n}
\r\n}
\r\n}
\r\n}
\r\n\r\n", "PostedDate": "2009-04-28T14:07:09.73-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "184714", "ThreadId": "54769", "Html": "It just doesn't make sense.
\r\n
\r\nIn scenario 1.
\r\n
\r\nI am creating a new ZipFile() inside a static method.
\r\n
\r\nIn the second case, I am calling new ZipFile() from the Main method which is also a static method. Why should the archive created in the first scenario be unrecognizable as a ZipFile (ZipFile.IsZipFile() returns false in scenario 1 but true in scenario 2)
\r\n
\r\n", "PostedDate": "2009-04-28T14:17:29.487-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "184735", "ThreadId": "54769", "Html": "I don't know what the problem might be, but I think you're on the right track. If the code works for you in one environment, you should be able to migrate it piecewise to the other environment.
\r\n
\r\n", "PostedDate": "2009-04-28T15:02:41.557-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "184957", "ThreadId": "54769", "Html": "Cheeso,
\r\n
\r\n           It's all on one platform. I am using Windows vista and Visual Studio 2008.
\r\n
\r\nWhen I create the archive directly, there's no problem.
\r\n
\r\nWhen I put the creation of the archive into a static method in a utility class and call it, it creates a zip file that is unusable. I don't know how this is even possible. The code is included in the first entry. Please try it and see if you can reproduce the problem.
\r\n
\r\nAll you would need apart from the two files is the following.
\r\n
\r\ndirectories
\r\nc:\\tmp\\dir1
\r\nc:\\tmp\\dir1\\dir2
\r\n
\r\nfiles
\r\nc:\\tmp\\crap.txt
\r\n
\r\nThanks for your time!!
\r\n", "PostedDate": "2009-04-29T06:22:29.347-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "185109", "ThreadId": "54769", "Html": "Hey, I looked into this further and it looks like it may be a bug in DotNetZip to me.
\r\nI will have to look more deeply into it, but it appears to be related to the comment on the archive.
\r\nIf I remove the line that sets the comment on the archive as it is created, then the archive can later be read successfully.
\r\n
\r\nI will investigate further, and get back to you.
\r\n
\r\n
\r\n
\r\n
\r\n", "PostedDate": "2009-04-29T10:53:35.407-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "185121", "ThreadId": "54769", "Html": "The problem you saw is a bug in DotNetZip
\r\nhttp://dotnetzip.codeplex.com/WorkItem/View.aspx?WorkItemId=7711
\r\n
\r\nTo workaround it, append 4 spaces to the comment text. 
\r\n
\r\n", "PostedDate": "2009-04-29T11:13:31.843-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "185148", "ThreadId": "54769", "Html": "Thanks Cheeso!!
\r\n
\r\n      You are a life-saver.
\r\n", "PostedDate": "2009-04-29T12:03:29.4-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "185159", "ThreadId": "54769", "Html": "H-
\r\nglad to help. You may want to get v1.7.2.13 - an update for v1.7.  That will fix the problem and eliminate the need for the workaround.
\r\n", "PostedDate": "2009-04-29T12:18:41.597-07:00", "UserRole": null, "MarkedAsAnswerDate": null } ]