When I unzip a file created by dotNetZip, it asks me for a password even though I didn't set one. The other weird issue is that it only happens sometimes. I can't figure out what could be causing it. Any ideas?
\r\nI am using version 1.8.4.21
\r\nCode
\r\n\r\n
ZipFile zipfile = new ZipFile(zipFileName);//create zip named zipFileName.zip \r\n zipfile.AddDirectory(sourceFolder,subfoldername);//add the sourceFolderContents to the zip file\r\n\r\n \r\n var pathToZip = destinationFolder + "\\\\" + zipFileName;\r\n zipfile.Save(pathToZip);//save file in the destination folder\r\n\r\n
Hi there.
\r\nHow do you unzip the file? using what? What "asks you" for a password?
\r\nThat code you show - do you have a using clause? or a try...finally? The ZipFile is IDisposable. Do you call ZipFile.Dispose()? You need to, when you're done. Look at any example - it will show how to do it.
\r\nFrom time to time there are bugs uncovered in the library. But I don't recall anything like this. I run lots and lots of tests, every time I post a release, and I never get a "ask for a password" when there was no password used.
\r\nThe first thing I would do, if I were you, is tighten up that code, and do a little more research on just when it asks for a password, and when your zip opener doesn't. Narrow it down.
\r\nI'm glad to help in any way. If you can show me code that reliably produces a broken zip file, I am definitely interested in that.
\r\n-Cheeso
\r\n", "PostedDate": "2009-10-28T19:25:04.743-07:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "250991", "ThreadId": "73426", "Html": "I'm using the built in windows zip program to unzip the file. That program prompts me for a password when I unzip the file. I am not calling ZipFile.Dispose(). I'll make that change, run some tests, and let you know what I find out.
\r\n\r\nFrom: Cheeso
Hi there.
\r\nHow do you unzip the file? using what? What "asks you" for a password?
\r\nThat code you show - do you have a using clause? or a try...finally? The ZipFile is IDisposable. Do you call ZipFile.Dispose()? You need to, when you're done. Look at any example - it will show how to do it.
\r\n\r\nFrom time to time there are bugs uncovered in the library. But I don't recall anything like this. I run lots and lots of tests, every time I post a release, and I never get a "ask for a password" when there was no password used.
\r\n\r\nThe first thing I would do, if I were you, is tighten up that code, and do a little more research on just when it asks for a password, and when your zip opener doesn't. Narrow it down.
\r\nI'm glad to help in any way. If you can show me code that reliably produces a broken zip file, I am definitely interested in that.
\r\n-Cheeso
\r\n
Read the full discussion online.
To add a post to this discussion, reply to this email (DotNetZip@discussions.codeplex.com)
\r\nTo start a new discussion for this project, email DotNetZip@discussions.codeplex.com
You are receiving this email because you subscribed to this discussion on CodePlex. You can unsubscribe on codePlex.com.
\r\nPlease note: Images and attachments will be removed from emails. Any posts to this discussion will also be available online at codeplex.com
Sounds great.
\r\nOh, another thing I noticed. In your code, you specify the name for the zipfile twice, and differently. You specify when instantiating the ZipFile object, and also when calling Save(). That really isn't necessary. Thinking about it now, there are 300+ tests, but I don't believe I have any tests that do *that. It just may be that it produces a screwy zip file, sometimes. I'll add some tests and investigate. But in the meantime, what I would suggest is that you specify the zipfile name, in one place or the other, but not both. Either in the constructor, or in the Save() call, but not both.
\r\nSomething like this:
\r\n// create a ZipFile object, with no backing store, just yet\r\nusing (ZipFile zipfile = new ZipFile()) // <<-- notice: no file name !\r\n{\r\n // add the sourceFolderContents to the zip file\r\n zipfile.AddDirectory(sourceFolder,subfoldername);\r\n\r\n // now, save file in the destination folder\r\n var pathToZip = System.IO.Path.Combine(destinationFolder, zipFileName);\r\n zipfile.Save(pathToZip);\r\n}\r\n\r\n\r\n
\r\n\r\nFrom: Cheeso
Sounds great.
\r\nOh, another thing I noticed. In your code, you specify the zipfile twice, and differently. You specify when instantiating the ZipFile object, and also when calling Save(). That really isn't necessary. Thinking about it now, I don't believe I have any tests that do *that*, and it just may be that it produces a screwy zip file, sometimes. What I would suggest is that you specify the zipfile name, in one place or the other, but not both. Either in the constructor, or in the Save() call, but not both.
\r\n\r\nSomething like this:
\r\n\r\n// create a ZipFile object, with no backing store, just yet\r\nusing (ZipFile zipfile = new ZipFile()) // <<-- notice: no file name !\r\n{\r\n // add the sourceFolderContents to the zip file\r\n zipfile.AddDirectory(sourceFolder,subfoldername);\r\n\r\n // now, save file in the destination folder\r\n var pathToZip = System.IO.Path.Combine(destinationFolder, zipFileName);\r\n zipfile.Save(pathToZip);\r\n}\r\n\r\n\r\nRead the full discussion online.
To add a post to this discussion, reply to this email (DotNetZip@discussions.codeplex.com)
\r\nTo start a new discussion for this project, email DotNetZip@discussions.codeplex.com
You are receiving this email because you subscribed to this discussion on CodePlex. You can unsubscribe on codePlex.com.
\r\nPlease note: Images and attachments will be removed from emails. Any posts to this discussion will also be available online at codeplex.com
\r\nFrom: bbolton
I ran this code in an asp.net website and kept getting the same prompt for a password when I upzipped it.
\r\n
var zipFileName = DateTime.Now.ToFileTime() + "test.zip";
var destinationFolder = @"F:\\Documents and Settings\\Administrator\\Desktop\\ZipTest\\ZipTest\\ZipTest\\zipto";
\r\n var pathToZip = System.IO.Path.Combine(destinationFolder, zipFileName);
var sourceFolder = @"F:\\Documents and Settings\\Administrator\\Desktop\\hic";
using (ZipFile zipFile = new ZipFile(pathToZip))
\r\n\r\n {
zipFile.AddDirectory(sourceFolder);
zipFile.Save();
}
I then decided to just make a simple console app with the same code above. Now when I unzip it, it doesn't ask for a password. That means DotNetZip isn't causing the error. Something to do with asp.net, IIS, or some other configuration.
\r\n\r\n
Thanks for your help.On Wed, Oct 28, 2009 at 10:47 PM, Cheeso <notifications@codeplex.com> wrote:\r\n\r\n\r\n\r\nFrom: Cheeso
Sounds great.
\r\nOh, another thing I noticed. In your code, you specify the zipfile twice, and differently. You specify when instantiating the ZipFile object, and also when calling Save(). That really isn't necessary. Thinking about it now, I don't believe I have any tests that do *that*, and it just may be that it produces a screwy zip file, sometimes. What I would suggest is that you specify the zipfile name, in one place or the other, but not both. Either in the constructor, or in the Save() call, but not both.
\r\n\r\n\r\nSomething like this:
\r\n\r\n// create a ZipFile object, with no backing store, just yet\r\nusing (ZipFile zipfile = new ZipFile()) // <<-- notice: no file name !\r\n{\r\n // add the sourceFolderContents to the zip file\r\n zipfile.AddDirectory(sourceFolder,subfoldername);\r\n\r\n // now, save file in the destination folder\r\n var pathToZip = System.IO.Path.Combine(destinationFolder, zipFileName);\r\n zipfile.Save(pathToZip);\r\n}\r\n\r\n\r\nRead the full discussion online.
To add a post to this discussion, reply to this email (DotNetZip@discussions.codeplex.com)
\r\n\r\nTo start a new discussion for this project, email DotNetZip@discussions.codeplex.com
You are receiving this email because you subscribed to this discussion on CodePlex. You can unsubscribe on codePlex.com.
\r\n\r\nPlease note: Images and attachments will be removed from emails. Any posts to this discussion will also be available online at codeplex.com
Read the full discussion online.
To add a post to this discussion, reply to this email (DotNetZip@discussions.codeplex.com)
\r\nTo start a new discussion for this project, email DotNetZip@discussions.codeplex.com
You are receiving this email because you subscribed to this discussion on CodePlex. You can unsubscribe on codePlex.com.
\r\nPlease note: Images and attachments will be removed from emails. Any posts to this discussion will also be available online at codeplex.com
DotNetZip should be fine with any valid Windows filename.
\r\nEarlier you said it worked in a Console application , but not in ASP.NET. Now you are suggesting the cause is the filenames. Have you tested this? what is the real answer? does it work in ASP.NET or not?
\r\nIt sounds like you have some testing to do. If I were you, I'd start with the very simple case, and then add complexity as you go.
\r\n", "PostedDate": "2009-10-30T02:15:27.327-07:00", "UserRole": null, "MarkedAsAnswerDate": null } ]