[ { "Id": "285422", "ThreadId": "83047", "Html": "

Hello.  I'm having an issue with the ZipFile.AddSelectedFiles function.    If the files I'm zipping contain a "~" and the directoryOnDisk I provide does not match the exact case of the path, I will get the full path in the zip archive, even when I specify an empty string for directoryPathInArchive.  Let me give an example.

\r\n

Let's say I have the following file "5.txt" in my folder "C:\\\\Test".  I want to zip this to somewhere on my harddrive.  I do the following.

\r\n
ZipFile z = new ZipFile();
\r\n
z.AddSelectedFiles("name != *.zip*", "C:\\\\Test\\\\", "", true);
\r\n
z.Save("C:\\\\Data\\\\zipfile.zip");
\r\n

Works as expected.  My zip archive contains "5.txt" and nothing else.

\r\n
z.AddSelectedFiles("name != *.zip*", "C:\\\\test\\\\", "", true);
\r\n

Also works even though "test" was not cased correctly to match the actual directory.  Now I rename "5.txt" to "~5.txt" and repeat the above line.

\r\n

The result is a zipfile containing Test\\~.5.txt.  The full path is present.  Now if I correctly type the directory such as:

\r\n
z.AddSelectedFiles("name != *.zip*", "C:\\\\Test\\\\", "", true);
\r\n

It works for "~" files.  I took a look at the source code and I may have found the issue.  On line 558 of ZipFile.Selector is the following:

\r\n
string dirInArchive = Path.GetDirectoryName(f).Replace(directoryOnDisk, directoryPathInArchive);
\r\n

It looks through each file and does a replace.  Path.GetDirectoryName however doesn't seem to return the correct path if the file contains a "~' and the case does not match the directory path.  Perhaps this may fix it?

\r\n
string dirInArchive = Path.GetDirectoryName(f).ToLower().Replace(directoryOnDisk, directoryPathInArchive);
\r\n

I'm not sure if this makes any sense at all but any input would be helpful.  I can send a sample project if necessary.

", "PostedDate": "2010-02-03T11:09:16.573-08:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "285425", "ThreadId": "83047", "Html": "

Sorry my fix suggestion is wrong haha.  This instead.

\r\n
string dirInArchive = Path.GetDirectoryName(f).ToLower().Replace(directoryOnDisk.ToLower(), directoryPathInArchive);
\r\n

Although the .ToLower() for directoryOnDisk could be done before the loop.

", "PostedDate": "2010-02-03T11:18:32.357-08:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "285474", "ThreadId": "83047", "Html": "This discussion has been copied to a work item. Click here to go to the work item and continue the discussion.", "PostedDate": "2010-02-03T13:09:55.447-08:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "288575", "ThreadId": "83047", "Html": "

Arbel, thanks for the analysis and the bug report. Very helpful .

\r\n

I've put the fix in; it will be available in v1.9.1.4, or v1.9.5.2. 

", "PostedDate": "2010-02-10T20:53:23.243-08:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "289957", "ThreadId": "83047", "Html": "

v1.9.1.4 is now available.  It includes this fix.

\r\n

 

", "PostedDate": "2010-02-11T20:21:07.907-08:00", "UserRole": null, "MarkedAsAnswerDate": null }, { "Id": "290135", "ThreadId": "83047", "Html": "

Thanks!

", "PostedDate": "2010-02-12T07:39:43.877-08:00", "UserRole": null, "MarkedAsAnswerDate": null } ]